Skip to content

Gha improvements #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 10, 2025
Merged

Gha improvements #532

merged 4 commits into from
Oct 10, 2025

Conversation

MarkWolters
Copy link
Contributor

Improvements to the GitHub workflow for regression testing

  1. Allow the user to pass in configuration to the job rather than always using default configuration
  2. Only run full regression on a code change (ie. one or more java files changed)
  3. fixed upload bug where upload step was looking for wrong filename when filename changed to eliminate illegal chars

@github-actions GitHub Actions
Copy link
Contributor

Before you submit for review:

  • Does your PR follow guidelines from CONTRIBUTIONS.md?
  • Did you summarize what this PR does clearly and concisely?
  • Did you include performance data for changes which may be performance impacting?
  • Did you include useful docs for any user-facing changes or features?
  • Did you include useful javadocs for developer oriented changes, explaining new concepts or key changes?
  • Did you trigger and review regression testing results against the base branch via Run Bench Main?
  • Did you adhere to the code formatting guidelines (TBD)
  • Did you group your changes for easy review, providing meaningful descriptions for each commit?
  • Did you ensure that all files contain the correct copyright header?

If you did not complete any of these, then please explain below.

tlwillke
tlwillke approved these changes Oct 10, 2025
View reviewed changes
Copy link
Collaborator

@tlwillke tlwillke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jshook
jshook approved these changes Oct 10, 2025
View reviewed changes
Copy link
Contributor

@jshook jshook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything to prevent this from merging

@tlwillke tlwillke merged commit a8565b5 into main Oct 10, 2025
13 checks passed
@tlwillke tlwillke deleted the gha_improvements branch October 10, 2025 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jshook jshook jshook approved these changes

@tlwillke tlwillke tlwillke approved these changes

@marianotepper marianotepper Awaiting requested review from marianotepper marianotepper is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MarkWolters @jshook @tlwillke